Skip to content

[docs] Replace alert with console.info #18316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 11, 2019
Merged

[docs] Replace alert with console.info #18316

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d91a134
[docs] Replace alert with console.info
eps1lon Nov 11, 2019
9257c25
Can't delete react
eps1lon Nov 11, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/src/pages/components/.eslintrc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
module.exports = {
rules: {
// useful for interactions feedback
'no-alert': 'off',
'no-console': ['off', { allow: ['info'] }],
// not very friendly to prop forwarding
'react/jsx-handler-names': 'off',
},
Expand Down
2 changes: 1 addition & 1 deletion docs/src/pages/components/breadcrumbs/CollapsedBreadcrumbs.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ const useStyles = makeStyles(theme => ({

function handleClick(event) {
event.preventDefault();
alert('You clicked a breadcrumb.');
console.info('You clicked a breadcrumb.');
}

export default function CollapsedBreadcrumbs() {
Expand Down
2 changes: 1 addition & 1 deletion docs/src/pages/components/breadcrumbs/CollapsedBreadcrumbs.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ const useStyles = makeStyles((theme: Theme) =>

function handleClick(event: React.MouseEvent<HTMLAnchorElement, MouseEvent>) {
event.preventDefault();
alert('You clicked a breadcrumb.');
console.info('You clicked a breadcrumb.');
}

export default function CollapsedBreadcrumbs() {
Expand Down
2 changes: 1 addition & 1 deletion docs/src/pages/components/breadcrumbs/CustomSeparator.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ const useStyles = makeStyles(theme => ({

function handleClick(event) {
event.preventDefault();
alert('You clicked a breadcrumb.');
console.info('You clicked a breadcrumb.');
}

export default function CustomSeparator() {
Expand Down
2 changes: 1 addition & 1 deletion docs/src/pages/components/breadcrumbs/CustomSeparator.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ const useStyles = makeStyles((theme: Theme) =>

function handleClick(event: React.MouseEvent<HTMLAnchorElement, MouseEvent>) {
event.preventDefault();
alert('You clicked a breadcrumb.');
console.info('You clicked a breadcrumb.');
}

export default function CustomSeparator() {
Expand Down
2 changes: 1 addition & 1 deletion docs/src/pages/components/breadcrumbs/CustomizedBreadcrumbs.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ const StyledBreadcrumb = withStyles(theme => ({

function handleClick(event) {
event.preventDefault();
alert('You clicked a breadcrumb.');
console.info('You clicked a breadcrumb.');
}

const useStyles = makeStyles(theme => ({
Expand Down
2 changes: 1 addition & 1 deletion docs/src/pages/components/breadcrumbs/CustomizedBreadcrumbs.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ const StyledBreadcrumb = withStyles((theme: Theme) => ({

function handleClick(event: React.MouseEvent<Element, MouseEvent>) {
event.preventDefault();
alert('You clicked a breadcrumb.');
console.info('You clicked a breadcrumb.');
}

const useStyles = makeStyles((theme: Theme) =>
Expand Down
2 changes: 1 addition & 1 deletion docs/src/pages/components/breadcrumbs/IconBreadcrumbs.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ const useStyles = makeStyles(theme => ({

function handleClick(event) {
event.preventDefault();
alert('You clicked a breadcrumb.');
console.info('You clicked a breadcrumb.');
}

export default function IconBreadcrumbs() {
Expand Down
2 changes: 1 addition & 1 deletion docs/src/pages/components/breadcrumbs/IconBreadcrumbs.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ const useStyles = makeStyles((theme: Theme) =>

function handleClick(event: React.MouseEvent<HTMLAnchorElement, MouseEvent>) {
event.preventDefault();
alert('You clicked a breadcrumb.');
console.info('You clicked a breadcrumb.');
}

export default function IconBreadcrumbs() {
Expand Down
2 changes: 1 addition & 1 deletion docs/src/pages/components/breadcrumbs/SimpleBreadcrumbs.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ const useStyles = makeStyles(theme => ({

function handleClick(event) {
event.preventDefault();
alert('You clicked a breadcrumb.');
console.info('You clicked a breadcrumb.');
}

export default function SimpleBreadcrumbs() {
Expand Down
2 changes: 1 addition & 1 deletion docs/src/pages/components/breadcrumbs/SimpleBreadcrumbs.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ const useStyles = makeStyles((theme: Theme) =>

function handleClick(event: React.MouseEvent<HTMLAnchorElement, MouseEvent>) {
event.preventDefault();
alert('You clicked a breadcrumb.');
console.info('You clicked a breadcrumb.');
}

export default function SimpleBreadcrumbs() {
Expand Down
2 changes: 1 addition & 1 deletion docs/src/pages/components/buttons/SplitButton.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ export default function SplitButton() {
const [selectedIndex, setSelectedIndex] = React.useState(1);

const handleClick = () => {
alert(`You clicked ${options[selectedIndex]}`);
console.info(`You clicked ${options[selectedIndex]}`);
};

const handleMenuItemClick = (event, index) => {
Expand Down
2 changes: 1 addition & 1 deletion docs/src/pages/components/buttons/SplitButton.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ export default function SplitButton() {
const [selectedIndex, setSelectedIndex] = React.useState(1);

const handleClick = () => {
alert(`You clicked ${options[selectedIndex]}`);
console.info(`You clicked ${options[selectedIndex]}`);
};

const handleMenuItemClick = (
Expand Down
4 changes: 2 additions & 2 deletions docs/src/pages/components/chips/Chips.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,11 +20,11 @@ export default function Chips() {
const classes = useStyles();

const handleDelete = () => {
alert('You clicked the delete icon.');
console.info('You clicked the delete icon.');
};

const handleClick = () => {
alert('You clicked the Chip.');
console.info('You clicked the Chip.');
};

return (
Expand Down
4 changes: 2 additions & 2 deletions docs/src/pages/components/chips/Chips.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,11 +22,11 @@ export default function Chips() {
const classes = useStyles();

const handleDelete = () => {
alert('You clicked the delete icon.');
console.info('You clicked the delete icon.');
};

const handleClick = () => {
alert('You clicked the Chip.');
console.info('You clicked the Chip.');
};

return (
Expand Down
7 changes: 1 addition & 6 deletions docs/src/pages/components/chips/ChipsArray.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,11 +27,6 @@ export default function ChipsArray() {
]);

const handleDelete = chipToDelete => () => {
if (chipToDelete.label === 'React') {
alert('Why would you want to delete React?! :)');
return;
}

setChipData(chips => chips.filter(chip => chip.key !== chipToDelete.key));
};

Expand All @@ -49,7 +44,7 @@ export default function ChipsArray() {
key={data.key}
icon={icon}
label={data.label}
onDelete={handleDelete(data)}
onDelete={data.label === 'React' ? undefined : handleDelete(data)}
className={classes.chip}
/>
);
Expand Down
7 changes: 1 addition & 6 deletions docs/src/pages/components/chips/ChipsArray.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,11 +34,6 @@ export default function ChipsArray() {
]);

const handleDelete = (chipToDelete: ChipData) => () => {
if (chipToDelete.label === 'React') {
alert('Why would you want to delete React?! :)');
Copy link
Member

@oliviertassinari oliviertassinari Nov 11, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one might be the only one it the code base that is justified. Without, it's unclear why clicking the delete button does nothing for React while it removes the other tags.

Copy link
Member Author

@eps1lon eps1lon Nov 11, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll rewrite this so it isn't handled in the first place. In the end why mark a chip as deletable if it isn't?

Copy link
Member

@oliviertassinari oliviertassinari Nov 11, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right 👌

return;
}

setChipData(chips => chips.filter(chip => chip.key !== chipToDelete.key));
};

Expand All @@ -56,7 +51,7 @@ export default function ChipsArray() {
key={data.key}
icon={icon}
label={data.label}
onDelete={handleDelete(data)}
onDelete={data.label === 'React' ? undefined : handleDelete(data)}
className={classes.chip}
/>
);
Expand Down
2 changes: 1 addition & 1 deletion docs/src/pages/components/chips/ChipsPlayground.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ function ChipsPlayground(props) {
};

const handleDeleteExample = () => {
alert('You clicked the delete icon.');
console.info('You clicked the delete icon.');
};

const colorToCode = color !== 'default' ? `color="${color}" ` : '';
Expand Down
4 changes: 2 additions & 2 deletions docs/src/pages/components/chips/OutlinedChips.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,11 +20,11 @@ export default function OutlinedChips() {
const classes = useStyles();

const handleDelete = () => {
alert('You clicked the delete icon.');
console.info('You clicked the delete icon.');
};

const handleClick = () => {
alert('You clicked the Chip.');
console.info('You clicked the Chip.');
};

return (
Expand Down
4 changes: 2 additions & 2 deletions docs/src/pages/components/chips/OutlinedChips.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,11 +22,11 @@ export default function OutlinedChips() {
const classes = useStyles();

const handleDelete = () => {
alert('You clicked the delete icon.');
console.info('You clicked the delete icon.');
};

const handleClick = () => {
alert('You clicked the Chip.');
console.info('You clicked the Chip.');
};

return (
Expand Down
4 changes: 2 additions & 2 deletions docs/src/pages/components/chips/SmallChips.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,11 +20,11 @@ export default function SmallChips() {
const classes = useStyles();

const handleDelete = () => {
alert('You clicked the delete icon.');
console.info('You clicked the delete icon.');
};

const handleClick = () => {
alert('You clicked the Chip.');
console.info('You clicked the Chip.');
};

return (
Expand Down
4 changes: 2 additions & 2 deletions docs/src/pages/components/chips/SmallChips.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,11 +22,11 @@ export default function SmallChips() {
const classes = useStyles();

const handleDelete = () => {
alert('You clicked the delete icon.');
console.info('You clicked the delete icon.');
};

const handleClick = () => {
alert('You clicked the Chip.');
console.info('You clicked the Chip.');
};

return (
Expand Down
4 changes: 2 additions & 2 deletions docs/src/pages/components/chips/SmallOutlinedChips.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,11 +20,11 @@ export default function SmallOutlinedChips() {
const classes = useStyles();

const handleDelete = () => {
alert('You clicked the delete icon.');
console.info('You clicked the delete icon.');
};

const handleClick = () => {
alert('You clicked the Chip.');
console.info('You clicked the Chip.');
};

return (
Expand Down
4 changes: 2 additions & 2 deletions docs/src/pages/components/chips/SmallOutlinedChips.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,11 +22,11 @@ export default function SmallOutlinedChips() {
const classes = useStyles();

const handleDelete = () => {
alert('You clicked the delete icon.');
console.info('You clicked the delete icon.');
};

const handleClick = () => {
alert('You clicked the Chip.');
console.info('You clicked the Chip.');
};

return (
Expand Down
2 changes: 1 addition & 1 deletion docs/src/pages/components/links/ButtonLink.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ export default function ButtonLink() {
component="button"
variant="body2"
onClick={() => {
alert("I'm a button.");
console.info("I'm a button.");
}}
>
Button Link
Expand Down
2 changes: 1 addition & 1 deletion docs/src/pages/components/links/ButtonLink.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ export default function ButtonLink() {
component="button"
variant="body2"
onClick={() => {
alert("I'm a button.");
console.info("I'm a button.");
}}
>
Button Link
Expand Down