[core] Fix missing type peer deps #17211
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eps1lon
added
type: bug
|
No bundle size changes comparing 3578ce2...c5a82a3 |
oliviertassinari
approved these changes
Aug 28, 2019
eps1lon
force-pushed
the
fix/type-deps
branch
from
320e0da to
e8c4e73
Compare
Member
Author
|
Node 8 has reached its end of life. |
eps1lon
added
PR: ready to ship
and removed
on hold
m4theushw
pushed a commit
to m4theushw/material-ui
that referenced
this pull request
Jan 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only merge if either node 8 has reached end of life (end of 2019) or npm was bumped in node 8 to 6.11
Closes #17121
peerDependenciesMetais implemented in[email protected],[email protected]andpnpm@?.Rule of thumb: If a type package has side effects it is a peer that has to be installed at app level. Otherwise you get type mismatches if different versions are installed. A side-effect is module augmentation which is most often used to make a type globally available (in react this happens by adding the JSX namespace). Packages without side-effects are usually safe to list as direct dependencies since multiple versions don't necessarily create clashes (here
@types/react-transition-group).