Skip to content

Conversation

@joshwooding
Copy link
Collaborator

@joshwooding joshwooding added type: new feature Expand the scope of the product to solve a new problem. docs Improvements or additions to the documentation. labels Apr 1, 2019
@mui-pr-bot
Copy link

mui-pr-bot commented Apr 1, 2019

No bundle size changes comparing 49bb455...af6a88c

Generated by 🚫 dangerJS against af6a88c

import { makeStyles } from '@material-ui/core/styles';
import ListItem from '@material-ui/core/ListItem';
import ListItemText from '@material-ui/core/ListItemText';
import { FixedSizeList } from 'react-window';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the react-window FAQs

If react-window provides the functionality your project needs, I would strongly recommend using it instead of react-virtualized.

I'm curious what the others think @mui-org/core-contributors

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And so we showcase the two dependencies, it's good for me.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do what the author says i.e. use react-window.

@oliviertassinari oliviertassinari merged commit 802d894 into mui:next Apr 2, 2019
@joshwooding joshwooding deleted the react-window-list branch April 2, 2019 22:03
@MastroLindus
Copy link

I was not aware of this PR.
I was also independently testing react-window with material-ui lists, and had a very similar implementation.

However personally I found the following issues:
1)ListItemSecondaryActions seems to be broken, I guess their positioning conflicts with react-window
2)ListSubheaders too are not working properly, I guess because of the sticky headers.
I just noticed this small paragraph in the docs of react-window: https://github.com/bvaughn/react-window#does-this-library-support-sticky-items
So i guess tomorrow I'll have a look at that.
3)On mobile the rendering of the rows is not fast enough if you scroll at a fast speed, therefore you see the list "white" until it has the time to render. It's not a deal breaker but it doesn't look great.

@sergiolenza
Copy link

Hi folks.
@MastroLindus did you found any solution for your second point?
I'm dealing with that issue right now and it seems it is impossible to achieve 😞
Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Improvements or additions to the documentation. type: new feature Expand the scope of the product to solve a new problem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants