-
-
Notifications
You must be signed in to change notification settings - Fork 32.7k
[docs] Add virtualized List example #15149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
joshwooding
commented
Apr 1, 2019
- I have followed (at least) the PR section of the contributing guide.
c49b272 to
9743cd6
Compare
|
No bundle size changes comparing 49bb455...af6a88c |
388a504 to
8891d65
Compare
| import { makeStyles } from '@material-ui/core/styles'; | ||
| import ListItem from '@material-ui/core/ListItem'; | ||
| import ListItemText from '@material-ui/core/ListItemText'; | ||
| import { FixedSizeList } from 'react-window'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What dependency should we use? https://npm-stat.com/charts.html?package=react-virtualized&package=react-window
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From the react-window FAQs
If react-window provides the functionality your project needs, I would strongly recommend using it instead of react-virtualized.
I'm curious what the others think @mui-org/core-contributors
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And so we showcase the two dependencies, it's good for me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do what the author says i.e. use react-window.
|
I was not aware of this PR. However personally I found the following issues: |
|
Hi folks. |