[ToggleButton] normalize onChange api #12549
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
eps1lon
force-pushed
the
feat-toggle-button-group-event
branch
from
743a1db to
c5e456e
Compare
mbrookes
added
the
breaking change
eps1lon
force-pushed
the
feat-toggle-button-group-event
branch
4 times, most recently
from
cafb1f3 to
298575d
Compare
This is a breaking change. Previously only the value was passed to the onChange callback despite the documentation mentioning the event as the first arg. Since every other on* callback in the core passes the event as the first argument we use the same approach here.
eps1lon
force-pushed
the
feat-toggle-button-group-event
branch
from
298575d to
ec6087e
Compare
marcelpanse
pushed a commit
to marcelpanse/material-ui
that referenced
this pull request
Oct 2, 2018
This is a breaking change. Previously only the value was passed to the onChange callback despite the documentation mentioning the event as the first arg. Since every other on* callback in the core passes the event as the first argument we use the same approach here.
oliviertassinari
added
scope: toggle button
oliviertassinari
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a breaking change.
Previously only the value was passed to the
onChangecallback despite the documentation mentioning the event as the first arg. Since every otheron*callback in the core passes the event as the first argument we use the same approach here.This component is currently listed under lab so breaking changes should be expected.
Closes #12546 although I'm not sure if this actually resolves that specific use case. One could make an argument to use the same approach as
SelectInputhttps://github.com/mui-org/material-ui/blob/62ef11d3485fd13ad11ac6dc2b2446aab5550d32/packages/material-ui/src/Select/SelectInput.js#L71 because that might be more likely to solve the specific use case mentioned. But thenTabuses the same approach asToogleButtonGrouphttps://github.com/mui-org/material-ui/blob/62ef11d3485fd13ad11ac6dc2b2446aab5550d32/packages/material-ui/src/Tab/Tab.js#L132Also closes #12326
Might be time to start a discussion how a consistent
onChangeapi for elements with children should look or if we want to avoid over abstraction here since changing the api in the core introduces breaking changes.