Skip to content

Conversation

@oliviertassinari
Copy link
Member

Closes #12270

@oliviertassinari oliviertassinari added docs Improvements or additions to the documentation. component: Autocomplete labels Jul 27, 2018
@oliviertassinari oliviertassinari merged commit ee9bc65 into mui:master Jul 27, 2018
@oliviertassinari oliviertassinari deleted the react-select-v2 branch July 27, 2018 23:36
@lucamartini
Copy link

Why did you remove the other autocomplete demos?

@oliviertassinari
Copy link
Member Author

What do you mean?

@lucamartini
Copy link

sorry I was not clear, but you added the react-select-v2 on the demo page, but in this commit you also removed the other demos:
https://material-ui.com/demos/autocomplete/
https://v1-3-0.material-ui.com/demos/autocomplete/
I was just asking if there was a reason (i.e. the other ways are not supported anymore, or ...)

@oliviertassinari
Copy link
Member Author

@lucamartini Oh, damn!

@oliviertassinari
Copy link
Member Author

@lucamartini Do you want to add them back? My mistake!

@lucamartini
Copy link

@oliviertassinari at my workplace we are using the downshift example, we were worried about that demo disappearance :-)
If it's not a big deal, we would appreciate that!

@oliviertassinari
Copy link
Member Author

@lucamartini I have commented the markdown working on the new demo. I have forgotten to undo the diff: https://github.com/mui-org/material-ui/pull/12307/files#diff-f9250f2f92b651e998e678b0a301a98c.
capture d ecran 2018-08-01 a 22 12 48
Let me know if you want to submit a pull request to add the demos back :).

@bogminic
Copy link
Contributor

bogminic commented Aug 3, 2018

@oliviertassinari I also think downshift example is important. Let me know if you want me to submit a weekend PR to fix this issue. Tnx!

@oliviertassinari
Copy link
Member Author

@bogminic Yes, please :)

@henkvhest
Copy link
Contributor

Is there a way to make the multiselect multiline? It currently looks like this when you have many selected items:
image

I tried multiline as a prop on the TextField component but that doesn't help :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Improvements or additions to the documentation. scope: autocomplete Changes related to the autocomplete. This includes ComboBox.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

react-select version v2 autocomplete example

4 participants