[typography] Add a allVariants key in the theme
#11802
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
added
the
type: new feature
| /* eslint-disable max-len */ | ||
| // Close to the bootstrap implementation: | ||
| // https://github.com/twbs/bootstrap/blob/8fccaa2439e97ec72a4b7dc42ccc1f649790adb0/scss/mixins/_grid.scss#L41 | ||
| /* eslint-enable max-len */ |
Member
|
Tricky. Just some ideas (not saying these are better): |
Member
Author
|
|
oliviertassinari
force-pushed
the
typography-variants
branch
from
143fc49 to
1e5625f
Compare
oliviertassinari
force-pushed
the
typography-variants
branch
from
1e5625f to
63f4f15
Compare
oliviertassinari
changed the title
allVariants key in the theme
Contributor
|
Seems like the typescript definition is not updated. I'll fix it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the issue history and my needs at the office, it can be quite handy to be able to override all the variants at once. It's what
theme.typography.variantsis for. Use case: a global reset.@mbrookes What do you think? Do you have a better wording in mind?