Skip to content

[Tooltip] - PopperProps broken starting from 4.9.5 #20095

@ValentinH

Description

@ValentinH

Because of #19851, we are not able to create our own custom arrow for a Tooltip.
image

  • The issue is present in the latest release.
  • I have searched the issues of this repository and believe that this is not a duplicate.

Current Behavior 😯

Passing an arrow modifier to PopperProps, throws Failed to execute 'contains' on 'Node': parameter 1 is not of type 'Node'.

Expected Behavior 🤔

The arrow is displayed properly.

Steps to Reproduce 🕹

Working version (4.9.4): https://codesandbox.io/s/material-demo-ltrt5
Broken version (4.9.5): https://codesandbox.io/s/material-demo-ddi25

Root cause

This is because deepmerge() replaces DOM nodes by {} objects.

Here a screenshot of the following console.log:

image
image

Your Environment 🌎

Tech Version
Material-UI v4.9.5
React v16.13.0
Browser Brave Version 1.3.118 Chromium: 80.0.3987.116 (Official Build) (64-bit)

Metadata

Metadata

Assignees

No one assigned

    Labels

    scope: tooltipChanges related to the tooltip.type: bugIt doesn't behave as expected.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions