[docs] Replace alert with console.info #18316
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
approved these changes
Nov 11, 2019
|
|
||
| const handleDelete = (chipToDelete: ChipData) => () => { | ||
| if (chipToDelete.label === 'React') { | ||
| alert('Why would you want to delete React?! :)'); |
Member
There was a problem hiding this comment.
This one might be the only one it the code base that is justified. Without, it's unclear why clicking the delete button does nothing for React while it removes the other tags.
Member
Author
There was a problem hiding this comment.
I'll rewrite this so it isn't handled in the first place. In the end why mark a chip as deletable if it isn't?
|
No bundle size changes comparing 575776f...9257c25 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces
alert()withconsole.info()becausealert()is quite disruptive (especially when testing keyboard interactions)