fix: treat undefined additionalProperties same false #131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as mentioned mtennoe#86 (comment) treat additionalProperties === undefined the same way as additionalProperties === false
mtennoe
reviewed
Nov 3, 2021
| swaggerType.additionalProperties === undefined | ||
| ) { | ||
| // is there an easier way to make an "any" type? | ||
| return makeAnyTypeSpec({ |
There was a problem hiding this comment.
Hm, why are we doing this change and not keeping the same makeAnyTypeSpec behavior?
| if ( | ||
| swaggerType.additionalProperties === undefined || | ||
| swaggerType.additionalProperties === true | ||
| swaggerType.additionalProperties === false || |
There was a problem hiding this comment.
Shouldn't the false-case be moved from this if check to the one on line 35 for false?
| if (swaggerType.type && swaggerType.type !== "object") { | ||
| return undefined; | ||
| } | ||
| if (swaggerType.additionalProperties === false) { |
There was a problem hiding this comment.
Can we add a test case for the updated behavior?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as mentioned #86 (comment)
treat additionalProperties === undefined the same way as additionalProperties === false
Microsoft Reviewers: Open in CodeFlow