fix: update is-browser.ts to account undefined navigator
#1868
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes electron 12.2.3, which doesn't have navigator defined mqttjs@6a03d29#commitcomment-142114121
cmoniz-ocean
changed the title
cmoniz-ocean
changed the title
cmoniz-ocean
referenced
this pull request
May 17, 2024
* fix(electron): detect electron env * fix(electron): cleanup code * fix: fixed wrong operator * fix(electron): improved code and add some comments * Update src/lib/is-browser.ts Co-authored-by: Daniel Lando <[email protected]> * fix: typo and lint --------- Co-authored-by: Daniel Lando <[email protected]>
robertsLando
changed the title
robertsLando
requested changes
May 17, 2024
Member
robertsLando
left a comment
robertsLando
left a comment
There was a problem hiding this comment.
Did you verified this is actually working on Electron?
src/lib/is-browser.ts
Outdated
| // check if we are in electron `renderer` | ||
| const electronRenderCheck = | ||
| (typeof navigator !== "undefined") && | ||
| navigator?.userAgent?.toLowerCase().indexOf(' electron/') > -1 |
Member
There was a problem hiding this comment.
Suggested change
| navigator?.userAgent?.toLowerCase().indexOf(' electron/') > -1 | |
| navigator.userAgent?.toLowerCase().indexOf(' electron/') > -1 |
Contributor
Author
There was a problem hiding this comment.
@robertsLando I've run npm run lint-fix and made the above changes #1868
Additionally, this has been npm run builded, npm packed, and then npm installed to my local electron 30 project and looks like it's working.
robertsLando
changed the title
undefined navigator
Member
|
Also pleasew fix lint issues with |
Contributor
|
I am happy to verify the changes later as well! |
This was referenced Jun 13, 2024
This was referenced Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes error
(error is thrown in electron 12.2.3 and electron 30.0.6)
6a03d29#commitcomment-142114121