Skip to content

Collect all child nodes of lists and tables in StructTree #20327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 29, 2025
Merged

Collect all child nodes of lists and tables in StructTree #20327

merged 4 commits into from
Oct 29, 2025

Conversation

@edoardocavazza
Copy link
Contributor

@edoardocavazza edoardocavazza commented Oct 2, 2025 •
edited
Loading

Attempt to fix #20324

Tree nodes are collected bottom-up, so I think it is safe when a list or table item is collected, to collect its children too

@edoardocavazza edoardocavazza mentioned this pull request Oct 3, 2025
Closed
timvandermeij
timvandermeij reviewed Oct 5, 2025
View reviewed changes
@timvandermeij timvandermeij changed the title Collect all child nodes of lists and tables in StrucTree Collect all child nodes of lists and tables in StructTree Oct 5, 2025
@calixteman
Copy link
Contributor

calixteman commented Oct 6, 2025

I need to think about that: I'm not sure it's the right approach.
I've a patch too for the original issue but I'm not sure it's the right approach too...

@edoardocavazza
Copy link
Contributor Author

edoardocavazza commented Oct 6, 2025

Added a unit test case

calixteman
calixteman reviewed Oct 13, 2025
View reviewed changes
calixteman
calixteman reviewed Oct 13, 2025
View reviewed changes
@calixteman
Copy link
Contributor

calixteman commented Oct 29, 2025

/botio test

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Oct 29, 2025

From: Bot.io (Linux m4)

Received

Command cmd_test from @calixteman received. Current queue size: 2

Live output at: http://54.241.84.105:8877/9a147146b04a569/output.txt

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Oct 29, 2025

From: Bot.io (Windows)

Received

Command cmd_test from @calixteman received. Current queue size: 2

Live output at: http://54.193.163.58:8877/ce0f3f506bb1c5d/output.txt

@calixteman
Copy link
Contributor

calixteman commented Oct 29, 2025

Oh I missed the PR has conflicts, @edoardocavazza could you rebase please ?

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Oct 29, 2025

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/9a147146b04a569/output.txt

Total script time: 0.20 mins

@edoardocavazza edoardocavazza force-pushed the collect-list-table-children branch from 2146cb2 to 17cdd9b Compare October 29, 2025 16:33
@edoardocavazza
Copy link
Contributor Author

edoardocavazza commented Oct 29, 2025

@calixteman done!

@calixteman
Copy link
Contributor

calixteman commented Oct 29, 2025

/botio test

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Oct 29, 2025

From: Bot.io (Windows)

Received

Command cmd_test from @calixteman received. Current queue size: 2

Live output at: http://54.193.163.58:8877/e9025612d8519c2/output.txt

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Oct 29, 2025

From: Bot.io (Linux m4)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/a37cd4f41381cdc/output.txt

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Oct 29, 2025

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/ce0f3f506bb1c5d/output.txt

Total script time: 0.48 mins

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Oct 29, 2025

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/a37cd4f41381cdc/output.txt

Total script time: 38.95 mins

  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: Passed

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Oct 29, 2025

From: Bot.io (Windows)

Success

Full output at http://54.193.163.58:8877/e9025612d8519c2/output.txt

Total script time: 79.65 mins

  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: Passed

calixteman
calixteman approved these changes Oct 29, 2025
View reviewed changes
Copy link
Contributor

@calixteman calixteman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you.

@calixteman calixteman merged commit 7fc5706 into mozilla:master Oct 29, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@timvandermeij timvandermeij timvandermeij left review comments

@calixteman calixteman calixteman approved these changes

Assignees

No one assigned

Labels

accessibility

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: Missing empty struct nodes via getStructTree

4 participants

@edoardocavazza @calixteman @moz-tools-bot @timvandermeij