[Editor] Pointer type initialization only when the user changes the mode #20226
Conversation
|
Should be closed after PR #20213 |
legraina
changed the title
|
@timvandermeij @calixteman Hi, I've merged the new master into this branch. It should be ready to merge, if good for you. |
Clear the pointer type of CurrentPointers outside of the DrawingEditor to always keep the same, until the user changes the mode. One of the goal is to keep the same pointer type in case of a refresh of the page or if the user changes the pdf document.
legraina
force-pushed
the
pointer-type-initialization
branch
from
7b5663b to
396cff5
Compare
|
The PR is ready. |
There was a problem hiding this comment.
Looks good to me, with passing integration tests, but I would like a review from @calixteman on this too before merging. Thanks!
|
/botio integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @timvandermeij received. Current queue size: 0 Live output at: http://54.241.84.105:8877/7214df943ba1e48/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @timvandermeij received. Current queue size: 0 Live output at: http://54.193.163.58:8877/d80ab657d3ce4b2/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/7214df943ba1e48/output.txt Total script time: 19.66 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/d80ab657d3ce4b2/output.txt Total script time: 43.95 mins
|
3 participants
It clears the pointer type of
CurrentPointersoutside of theDrawingEditorto always keep the same, until the user changes the mode.One of the goal is to keep the same pointer type in case of a refresh of the page or if the user changes the pdf document.