Skip to content

Get the first codepoint instead of the first char when using the toUnicode map #19184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 6, 2024
Merged

Get the first codepoint instead of the first char when using the toUnicode map #19184

merged 1 commit into from
Dec 6, 2024

Conversation

@calixteman
Copy link
Contributor

@calixteman calixteman commented Dec 6, 2024 •
edited
Loading

It fixes #19182.

@calixteman
Copy link
Contributor Author

/botio test

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_test from @calixteman received. Current queue size: 1

Live output at: http://54.241.84.105:8877/567e2f58b2c6e0d/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_test from @calixteman received. Current queue size: 1

Live output at: http://54.193.163.58:8877/a8dddbb0598dacd/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/567e2f58b2c6e0d/output.txt

Total script time: 29.06 mins

  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: Passed

@calixteman calixteman marked this pull request as ready for review December 6, 2024 15:50
@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Success

Full output at http://54.193.163.58:8877/a8dddbb0598dacd/output.txt

Total script time: 51.12 mins

  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: Passed

Snuffleupagus
Snuffleupagus approved these changes Dec 6, 2024
View reviewed changes
Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hopefully this won't break something where our test-coverage is lacking, but I suppose that we'll need to land this to find out if that's the case.

r=me, thank you.

@calixteman calixteman merged commit 23c42f8 into mozilla:master Dec 6, 2024
9 checks passed
@calixteman
Copy link
Contributor Author

/botio makeref

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_makeref from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/7bac121055bdb73/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_makeref from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/dde62a4f50cf9b5/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/7bac121055bdb73/output.txt

Total script time: 17.34 mins

  • Make references: Passed
  • Check references: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Success

Full output at http://54.193.163.58:8877/dde62a4f50cf9b5/output.txt

Total script time: 26.64 mins

  • Make references: Passed
  • Check references: Passed

maettuu added a commit to maettuu/pdf.js-test-generation that referenced this pull request Aug 6, 2025
@maettuu
Add regression test for Unicode mapping
5b239fd 
Verifies that ToUnicodeMap correctly maps Extension B characters to their full Unicode code points using codePointAt

See PR mozilla#19184
@maettuu maettuu mentioned this pull request Aug 6, 2025
Open
maettuu added a commit to maettuu/pdf.js-test-generation that referenced this pull request Sep 4, 2025
@maettuu
Add regression test for Unicode mapping
2d8dfb0 
Verifies that ToUnicodeMap correctly maps Extension B characters to their full Unicode code points using codePointAt

See PR mozilla#19184
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Snuffleupagus Snuffleupagus Snuffleupagus approved these changes

Assignees

No one assigned

Labels

font-conversion

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: Pming liu Extension B characters in form fields does not render in pdf.js viewer

3 participants

@calixteman @moz-tools-bot @Snuffleupagus