[Bug]: JS of a button is not executed

[g19i85g]

Attach (recommended) or Link to PDF file

three_buttons_same_name.pdf

Web browser and its version

Firefox 134.0 (64-Bit)

Operating system and its version

Linux

PDF.js version

v4.10.38

Is the bug present in the latest PDF.js version?

Yes

Is a browser extension

No

Steps to reproduce the problem

1. open the PDF in PDF.js
2. klick on the button "set text to BBB"

What is the expected behavior?

The text field should contain “BBB”.

What went wrong?

If several buttons with the same name exist. Only the JavaScript of the first button is executed, regardless of which button is pressed.

Link to a viewer

No response

Additional context

No response

[Snuffleupagus]

Part of the problem appears to be at

pdf.js/src/scripting_api/initialization.js

Lines 89 to 92 in b0b9552

	if (annotations.length > 0) {
	obj = annotations[0];
	obj.send = send;
	}

since we're only parsing the first button here.

The other buttons don't get their own Field-instances, but are only handled via

pdf.js/src/scripting_api/initialization.js

Line 99 in b0b9552

const otherFields = annotations.slice(1);

and

pdf.js/src/scripting_api/initialization.js

Lines 112 to 115 in b0b9552

	if (otherFields.length > 0) {
	obj.siblings = otherFields.map(x => x.id);
	}
	field = new Field(obj);

This is as far as I've got, given my very limited knowledge of the scripting-API. /cc @calixteman

[Youngemmy5956]

@g19i85g @Snuffleupagus

I created a pull request that fixed the current issues.