Skip to content

fix(bin): enable pacing on client & server by default #1753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 17, 2024
Merged

fix(bin): enable pacing on client & server by default #1753

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
55aa856
fix(bin): enable pacing on server by default
mxinden Mar 16, 2024
357002e
fix(bin): enable pacing by default and add optional --no-pacing
mxinden Mar 17, 2024
654dfe7
Update test/upload_test.sh
mxinden Mar 17, 2024
fb324a2
Update comment
mxinden Mar 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions neqo-bin/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,9 +89,9 @@ pub struct QuicParameters {
/// The congestion controller to use.
pub congestion_control: CongestionControlAlgorithm,

#[arg(long = "pacing")]
/// Whether pacing is enabled.
pub pacing: bool,
#[arg(long = "no-pacing")]
/// Whether to disable pacing.
pub no_pacing: bool,

#[arg(name = "preferred-address-v4", long)]
/// An IPv4 address for the server preferred address.
Expand Down Expand Up @@ -162,7 +162,7 @@ impl QuicParameters {
.max_streams(StreamType::UniDi, self.max_streams_uni)
.idle_timeout(Duration::from_secs(self.idle_timeout))
.cc_algorithm(self.congestion_control)
.pacing(self.pacing);
.pacing(!self.no_pacing);

if let Some(&first) = self.quic_version.first() {
let all = if self.quic_version[1..].contains(&first) {
Expand Down
7 changes: 4 additions & 3 deletions test/upload_test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,10 @@ cc=cubic
client="cargo run --release --bin neqo-client -- http://$server_address:$server_port/ --test upload --upload-size $upload_size --cc $cc"
server="cargo run --release --bin neqo-server -- --db ../test-fixture/db $server_address:$server_port"
server_pid=0
pacing=true
if [ "$pacing" = true ]; then
client="$client --pacing"
no_pacing=false
if [ "$no_pacing" = true ]; then
client="$client --no-pacing"
server="$server --no-pacing"
fi

# Define two indexed arrays to store network conditions
Expand Down