Check for CMSE ABI's as well #1093
Open
+74
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilio
approved these changes
Jul 28, 2025
emilio
reviewed
Jul 30, 2025
| if let Some(ref lit_string) = self.name { | ||
| matches!( | ||
| lit_string.value().as_str(), | ||
| "cmse-nonsecure-entry" | "cmse-nonsecure-call" |
There was a problem hiding this comment.
Hmm, I'm not sure why these function shouldn't be tagged with __attribute__((cmse_nonsecure_call)) and __attribute__((cmse_nonsecure_entry)), respectively. Mind elaborating on that?
There was a problem hiding this comment.
Off the top of my head, that's because these annotations instruct the compiler to create veneers for these functions which is only important at their definition (in rust), call sites shouldn't care about this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rust has nightly support for Cortex-M Security Extension through the
cmse-nonsecure-entryandcmse-nonsecure-callABIs. These are compatible with C but cause the compiler to emit extra instructions for things such as clearing sensitive registers before jumps.Therefore it would be convenient if cbindgen was able to generate declarations for functions annotated with these CMSE ABIs as well. This PR adds basic support for these ABIs by slightly relaxing the filter.