Skip to content

MNTOR-5107: Add test for recent bug #6266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

MNTOR-5107: Add test for recent bug #6266

wants to merge 1 commit into from

Conversation

@Vinnl
Copy link
Collaborator

@Vinnl Vinnl commented Nov 13, 2025

References:

Jira: MNTOR-5107
Figma:

Description

This test case would result in an invalid state previously:

it should show a call to the manual resolution flow for free users with
existing scans, when the FreeOnly flag is enabled

It's a followup to #6263 (comment).

Checklist (Definition of Done)

  • Localization strings (if needed) have been added.
  • Commits in this PR are minimal and have descriptive commit messages.
  • I've added or updated the relevant sections in readme and/or code comments
  • I've added a unit test to test for potential regressions of this bug.
  • If this PR implements a feature flag or experimentation, I've checked that it still works with the flag both on, and with the flag off.
  • If this PR implements a feature flag or experimentation, the Ship Behind Feature Flag status in Jira has been set
  • Product Owner accepted the User Story (demo of functionality completed) or waived the privilege.
  • All acceptance criteria are met.
  • Jira ticket has been updated (if needed) to match changes made during the development process.
  • Jira ticket has been updated (if needed) with suggestions for QA when this PR is deployed to stage.

@Vinnl Vinnl requested a review from kschelonka November 13, 2025 13:15
@Vinnl Vinnl self-assigned this Nov 13, 2025
@Vinnl Vinnl added the Review: XS Code review time: up to 30min label Nov 13, 2025
@Vinnl Vinnl mentioned this pull request Nov 13, 2025
Merged
10 tasks
@Vinnl
Add test for recent bug
df78789 
This test case would result in an invalid state previously:
> it should show a call to the manual resolution flow for free users with
> existing scans, when the `FreeOnly` flag is enabled
codemist
codemist reviewed Nov 13, 2025
View reviewed changes
...n)/(authenticated)/user/(dashboard)/dashboard/DashboardTopBanner/DashboardTopBanner.test.tsx
@@ -0,0 +1,213 @@
/* This Source Code Form is subject to the terms of the Mozilla Public
Copy link
Collaborator

@codemist codemist Nov 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious why there's a new test file for this, since the other dashboard top banner test variations were in Dashboard.test.tsx?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@codemist codemist codemist left review comments

@kschelonka kschelonka Awaiting requested review from kschelonka

At least 1 approving review is required to merge this pull request.

Assignees

@Vinnl Vinnl

Labels

Review: XS Code review time: up to 30min

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Vinnl @codemist