Configure ESLint

[willdurand]

Fixes #17
Fixes #75

---

There are 3 warnings due to JSX not being supported by ESLint anymore: https://eslint.org/blog/2015/03/eslint-0.17.0-released#changes-to-jsxreact-handling.

I think it could maybe be fixed automagically by upgrading some of our dependencies, but it requires some work on https://github.com/mozilla/eslint-config-amo (which is on my todo-list).

[codecov-io]

Codecov Report

Merging #74 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master      #74   +/-   ##
=======================================
  Coverage   62.59%   62.59%           
=======================================
  Files          10       10           
  Lines         131      131           
  Branches       26       26           
=======================================
  Hits           82       82           
  Misses         45       45           
  Partials        4        4

Impacted Files	Coverage Δ
src/configureStore.tsx	62.5% <ø> (ø)	⬆️
src/reducers/example.tsx	85.71% <ø> (-1.79%)	⬇️
src/index.tsx	0% <ø> (ø)	⬆️
src/components/App/index.tsx	38.46% <ø> (ø)	⬆️
src/server/index.js	63.88% <ø> (ø)	⬆️
src/api/index.tsx	100% <100%> (ø)	⬆️
src/components/DiffView/index.tsx	100% <100%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a900ade...b425d0b. Read the comment docs.

[bobsilverberg]

This looks good to me, and it works well with my IDE as well. Nice job @willdurand!

[kumar303]

If it's not too crazy, how about squeezing this in? https://github.com/prettier/eslint-config-prettier Otherwise it could be done in a separate PR. Disabling the rules made moot by prettier would be nice and could possibly speed up our linting.

[willdurand]

I pushed a new commit with more types.. The ESLint TS config wanted moaar!

I (will) made some changes

[willdurand]

So upgrading the eslint dependencies did not remove the warnings:

$ eslint --ext .js --ext tsx src/

/Users/williamdurand/projects/mozilla/addons-code-manager/src/components/App/index.test.tsx
  19:5  warning  'authToken' is assigned a value but never used  @typescript-eslint/no-unused-vars

/Users/williamdurand/projects/mozilla/addons-code-manager/src/components/App/index.tsx
  5:8  warning  'styles' is defined but never used  @typescript-eslint/no-unused-vars

/Users/williamdurand/projects/mozilla/addons-code-manager/src/components/LoginButton/index.tsx
  3:8  warning  'styles' is defined but never used  @typescript-eslint/no-unused-vars

/Users/williamdurand/projects/mozilla/addons-code-manager/src/index.tsx
  11:7  warning  'store' is assigned a value but never used  @typescript-eslint/no-unused-vars

✖ 4 problems (0 errors, 4 warnings)

[willdurand]

rebased again

[willdurand]

I found the issue related to the JSX and false-positives, a fix has been merged < 24h ago: typescript-eslint/typescript-eslint#161 and I confirm it works.

[willdurand]

This is now ready 🚀

[willdurand]

I found the issue related to the JSX and false-positives, a fix has been merged < 24h ago: typescript-eslint/typescript-eslint#161 and I confirm it works.

I added another commit to use the canary release of the plugin.

[kumar303]

If it's not too crazy, how about squeezing this in? https://github.com/prettier/eslint-config-prettier

I deferred it to #84

[kumar303]

Here is an incomplete review before the status meeting.

[kumar303]

...continuing my review

[willdurand]

I fixed all the comments, thanks!

[kumar303]

r+wc

Just a few minor things to clean up