Propagate morpho-v1 setup #94
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rubilmax
requested review from
MathisGD,
MerlinEgalite,
QGarchery and
pakim249CAL
pakim249CAL
approved these changes
Dec 15, 2022
MathisGD
approved these changes
Dec 20, 2022
Collaborator
MathisGD
left a comment
MathisGD
left a comment
There was a problem hiding this comment.
Not a fan of Makefiles for solidity but not a blocker
MerlinEgalite
approved these changes
Dec 21, 2022
QGarchery
previously requested changes
Dec 22, 2022
Collaborator
QGarchery
left a comment
QGarchery
left a comment
There was a problem hiding this comment.
Looks good, one change requested
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
src/and forge tests undertest/, so I propagatedmorpho-v1's setupMakefileseems to have been removed in favor of a pureforgesetup. However, it still enables some handy shortcuts to the dev, increasing the devexp (at least to me). Can we have it back?