Skip to content

Correct testing behavior for safe cast #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 19, 2022
Merged

Correct testing behavior for safe cast #91

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
20d6589
fix: correct testing behavior for safe cast
MerlinEgalite Dec 10, 2022
c963b33
test: add fuzzing
MerlinEgalite Dec 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions test-foundry/TestCommonHeapOrdering.t.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -336,13 +336,17 @@ abstract contract TestCommonHeapOrdering is Test {
assertEq(heap.indexOf(accounts[3]), 3);
}

function testOverflowNewValue() public {
function testOverflowNewValue(uint256 value) public {
vm.assume(value > type(uint96).max);

vm.expectRevert("SafeCast: value doesn't fit in 96 bits");
update(accounts[0], 0, uint256(type(uint128).max));
update(accounts[0], 0, value);
}

function testOverflowFormerValue() public {
function testOverflowFormerValue(uint256 value) public {
vm.assume(value > type(uint96).max);

vm.expectRevert("SafeCast: value doesn't fit in 96 bits");
update(accounts[0], uint256(type(uint128).max), 0);
update(accounts[0], value, 0);
}
}