DRIVERS-2366 Use camelCase for ReadPreference mode in unified tests #1296
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickfreed
requested review from
jmikola and
nbbeeken
and removed request for
a team
Contributor
|
Java driver does a toLower on the mode, so this didn't come up. No need for a separate ticket. |
ShaneHarvey
approved these changes
Aug 22, 2022
Member
ShaneHarvey
left a comment
ShaneHarvey
left a comment
There was a problem hiding this comment.
Python also lowercases so this works just fine.
jyemin
approved these changes
Aug 23, 2022
dariakp
approved these changes
Aug 23, 2022
jmikola
approved these changes
Aug 23, 2022
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the capitalization of a ReadPreference mode in one of the SDAM unified tests. It currently reads
Secondary, which is consistent with existing server selection and max-staleness tests but inconsistent with existing unified format tests (this CRUD unified test usessecondaryPreferred, for example).This PR also updates the unified test format changelog to mention the addition of the
createEntitiesoperation.Thanks to @dariakp for noticing these issues.
@ShaneHarvey @jyemin would you prefer if there was a separate DRIVERS ticket for this since you both already implemented the original change? Or do you just want to sync this in real quick as a one-off? Happy to do either, just figured I'd check before making some Jira noise.