Skip to content

test(NODE-3237): migrate legacy spec tests to unified format #4180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jul 19, 2024
Merged

test(NODE-3237): migrate legacy spec tests to unified format #4180

merged 10 commits into from
Jul 19, 2024

Conversation

@baileympearson
Copy link
Contributor

@baileympearson baileympearson commented Jul 17, 2024 •
edited by nbbeeken
Loading

Description

NODE-3211,NODE-3213,NODE-5975,NODE-5976,NODE-5984,NODE-6004,NODE-6005

What is changing?

Migrates all legacy spec tests except for FLE to the unified test format. All spec tests are from the latest master in the specs repo.

This PR syncs:

  • read/write concern
  • gridfs
  • retryable writes
  • retryable reads
  • crud v1
  • crud v2
  • Atlas data lake tests
Is there new documentation needed for these changes?

No.

What is the motivation for this change?

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@baileympearson baileympearson force-pushed the NODE-5984 branch 2 times, most recently from 00c4853 to 6da296f Compare July 17, 2024 17:59
@baileympearson baileympearson changed the title remove all old tests test(NODE-3211,NODE-3213,NODE-5975,NODE-5976,NODE-5984,NODE-6004,NODE-6005): migrate legacy spec tests to unified test format Jul 17, 2024
@baileympearson baileympearson mentioned this pull request Jul 17, 2024
Closed
5 tasks
@baileympearson baileympearson marked this pull request as ready for review July 17, 2024 19:27
baileympearson
baileympearson commented Jul 17, 2024
View reviewed changes
@W-A-James W-A-James self-assigned this Jul 18, 2024
@W-A-James W-A-James added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Jul 18, 2024
@W-A-James W-A-James requested review from W-A-James and removed request for W-A-James July 18, 2024 14:45
@W-A-James W-A-James removed their assignment Jul 18, 2024
@nbbeeken nbbeeken changed the title test(NODE-3211,NODE-3213,NODE-5975,NODE-5976,NODE-5984,NODE-6004,NODE-6005): migrate legacy spec tests to unified test format test(NODE-3237): migrate legacy spec tests to unified format Jul 18, 2024
aditi-khare-mongoDB
aditi-khare-mongoDB approved these changes Jul 19, 2024
View reviewed changes
Copy link
Contributor

@aditi-khare-mongoDB aditi-khare-mongoDB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nbbeeken nbbeeken merged commit 357ca08 into main Jul 19, 2024
@nbbeeken nbbeeken deleted the NODE-5984 branch July 19, 2024 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@nbbeeken nbbeeken nbbeeken approved these changes

@aditi-khare-mongoDB aditi-khare-mongoDB aditi-khare-mongoDB approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@aditi-khare-mongoDB aditi-khare-mongoDB

Labels

Primary Review In Review with primary reviewer, not yet ready for team's eyes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@baileympearson @nbbeeken @aditi-khare-mongoDB @W-A-James