Skip to content

Conversation

@nbbeeken
Copy link
Contributor

@nbbeeken nbbeeken commented May 7, 2024

Description

What is changing?

  • release please files present on 5.x
  • back sync changes to main
    • workflows run off of the default branch, sync-ing is just for sanity, when reading this branch it can be confusing that the flows are still as they were when this used to be the default.
Is there new documentation needed for these changes?

What is the motivation for this change?

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@W-A-James W-A-James self-assigned this May 7, 2024
@W-A-James W-A-James added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label May 7, 2024
@W-A-James W-A-James self-requested a review May 7, 2024 21:50
@W-A-James W-A-James merged commit 8d55f7d into 5.x May 7, 2024
@W-A-James W-A-James deleted the NODE-6033-release-please-manifest branch May 7, 2024 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Primary Review In Review with primary reviewer, not yet ready for team's eyes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants