-
Notifications
You must be signed in to change notification settings - Fork 1.8k
refactor(NODE-5912): make server.command an async function #3986
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Currently only consistently failing these two tests across load-balanced variants. It seems strange to me that we'd fail operation count tests, but not connection pinning tests. |
…opology-lifecycle.json
8e5d24b to
7400c87
Compare
|
A couple of housekeeping questions:
|
baileympearson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pending CI, LGTM
|
CI fails because the AWS Secrets Secrets Manager is not implemented yet NODE-5507 and Serverless credentials are rotated (should be fixed soon). |
Description
What is changing?
Server.commandis now written with explicit async/await syntaxServer.commandAsyncand replaced all referencesConnectionPool.withConnection,ConnectionPool.withReauthentiationConnectionPool.reauthenticateto use explicit async/await syntax and exported it for internal use inServer.commandConnectionPool.checkOutto use async/await syntax with the support ofpromiseWithResolvershelper functioncallbackproperty fromWaitQueueMemberand replaced it with explicitrejectandresolveproperties for more ergonomic use withpromiseWithResolversinConnectionPool.checkOutWhat is the motivation for this change?
NODE-5912, NODE-5913
Double check the following
npm run check:lintscripttype(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript