Skip to content

fix(NODE-5901): propagate errors to transformed stream in cursor #3985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 13, 2024
Merged

fix(NODE-5901): propagate errors to transformed stream in cursor #3985

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
929a6cd
fix: propagate errors to transformed stream in cursor
vkarpov15 Feb 5, 2024
9deebbd
test: add test case covering transform streams throwing a MongoServer…
vkarpov15 Feb 8, 2024
4b682d9
Merge branch 'main' into vkarpov15/mongoose-14304
durran Feb 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/cursor/abstract_cursor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -337,7 +337,7 @@ export abstract class AbstractCursor<
const transform = options.transform;
const readable = new ReadableCursorStream(this);

return readable.pipe(
const transformedStream = readable.pipe(
new Transform({
objectMode: true,
highWaterMark: 1,
Expand All @@ -351,6 +351,12 @@ export abstract class AbstractCursor<
}
})
);

// Bubble errors to transformed stream, because otherwise no way
// to handle this error.
readable.on('error', err => transformedStream.emit('error', err));

return transformedStream;
}

return new ReadableCursorStream(this);
Expand Down