Skip to content

test(NODE-5852): Skip transaction unpin spec tests #3980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 1, 2024
Merged

test(NODE-5852): Skip transaction unpin spec tests #3980

Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
36744f9
ready for review
aditi-khare-mongoDB Jan 25, 2024
b04f402
PR requested changes
aditi-khare-mongoDB Jan 29, 2024
23f1107
test fix
aditi-khare-mongoDB Jan 31, 2024
7185bfc
test fix actual
aditi-khare-mongoDB Jan 31, 2024
7ff5aab
Add transaction started to skipped tests
aditi-khare-mongoDB Feb 1, 2024
08c990d
add read/write into skip as well (all remaining transacation tests
aditi-khare-mongoDB Feb 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions test/integration/transactions/transactions.spec.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
'use strict';

import { gte } from 'semver';

const path = require('path');
const { expect } = require('chai');
const { TestRunnerContext, generateTopologyTests } = require('../../tools/spec-runner');
Expand Down Expand Up @@ -93,6 +95,14 @@ const SKIP_TESTS = [
'Client side error when transaction is in progress'
];

const LATEST_SKIP_TESTS = [
// TODO(NODE-5855): Unskip Transactions Spec Unified Tests mongos-unpin.unpin
'unpin after TransientTransactionError error on commit',
Copy link
Contributor

@nbbeeken nbbeeken Jan 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We discussed only skipping on latest, which is a smoke test anyway, these tests still pass for servers that are used in production, we can continue to make sure these work on those servers.

Copy link
Contributor Author

@aditi-khare-mongoDB aditi-khare-mongoDB Jan 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the reminder, I've changed it to skipped on latest.

Copy link
Contributor

@nbbeeken nbbeeken Jan 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still see the test failing in EVG:

https://spruce.mongodb.com/task/mongo_node_driver_next_windows_vsCurrent_large_gallium_test_latest_sharded_cluster_patch_8f7bb593cbd1b2cd69c76702dbd1125479d1055a_65b7f9f6850e61525b80a452_24_01_29_19_18_15/logs?execution=0&sortBy=STATUS&sortDir=ASC

Is the server version correct?

Copy link
Contributor Author

@aditi-khare-mongoDB aditi-khare-mongoDB Jan 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant I skipped it within the code.

'unpin on successful abort',
'unpin after non-transient error on abort',
'unpin after TransientTransactionError error on abort'
];

describe('Transactions Spec Legacy Tests', function () {
const testContext = new TransactionsRunnerContext();
if (process.env.SERVERLESS) {
Expand All @@ -113,8 +123,11 @@ describe('Transactions Spec Legacy Tests', function () {
return testContext.setup(this.configuration);
});

function testFilter(spec) {
return SKIP_TESTS.indexOf(spec.description) === -1;
function testFilter(spec, configuration) {
return (
SKIP_TESTS.indexOf(spec.description) === -1 &&
(!gte(configuration.version, '7.1.0') || LATEST_SKIP_TESTS.indexOf(spec.description) === -1)
);
}

generateTopologyTests(testSuites, testContext, testFilter);
Expand Down