Skip to content

Conversation

@dariakp
Copy link
Contributor

@dariakp dariakp commented Sep 29, 2022

Description

NODE-2988

  • Adding an SDAM prose test to make sure monitors wait minHeartbeatFrequencyMS between checks

Note: the new test is currently failing, possibly due to work not yet done in: #3404

What is changing?

Is there new documentation needed for these changes?

What is the motivation for this change?

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: <type>(NODE-xxxx)<!>: <description>
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@baileympearson baileympearson changed the title test(NODE-2998): monitors wait minHeartbeatFrequencyMS between checks test(NODE-2988): monitors wait minHeartbeatFrequencyMS between checks Sep 30, 2022
@dariakp dariakp marked this pull request as ready for review September 30, 2022 16:26
@baileympearson baileympearson added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Sep 30, 2022
@baileympearson baileympearson merged commit 6aeff81 into main Sep 30, 2022
@baileympearson baileympearson deleted the NODE-2998/test-500ms-between-failed-hello-checks branch September 30, 2022 16:38
ZLY201 pushed a commit to ZLY201/node-mongodb-native that referenced this pull request Nov 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Primary Review In Review with primary reviewer, not yet ready for team's eyes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants