test(NODE-4562): reduce macos coverage #3381
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
durran
requested changes
Aug 24, 2022
durran
added
the
Primary Review
durran
approved these changes
Aug 24, 2022
Member
durran
left a comment
durran
left a comment
There was a problem hiding this comment.
Looks like a rebase then LGTM.
durran
added
Team Review
durran
requested changes
Aug 24, 2022
baileympearson
force-pushed
the
NODE-4562-reduce-macos-testing
branch
from
4a79978 to
eb42288
Compare
baileympearson
force-pushed
the
NODE-4562-reduce-macos-testing
branch
from
550702d to
4e5abd1
Compare
nbbeeken
reviewed
Aug 24, 2022
Contributor
nbbeeken
left a comment
nbbeeken
left a comment
There was a problem hiding this comment.
Do we want to consider replica set just so we can continue testing change streams on mac os? It's one notable area that would be omitted with a standalone only task
durran
previously approved these changes
Aug 25, 2022
Member
durran
left a comment
durran
left a comment
There was a problem hiding this comment.
I guess 11 has the same timeout issue so I guess we just have to expect it on any MacOS.
durran
approved these changes
Aug 25, 2022
nbbeeken
approved these changes
Aug 26, 2022
durran
pushed a commit
that referenced
this pull request
Aug 30, 2022
durran
pushed a commit
that referenced
this pull request
Aug 31, 2022
baileympearson
added a commit
that referenced
this pull request
Aug 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is changing?
This PR updates our CI matrix to only test the rapid release on a standalone server on macos.
Is there new documentation needed for these changes?
No.
What is the motivation for this change?
Green CI.
Double check the following
npm run check:lintscript<type>(NODE-xxxx)<!>: <description>