Skip to content

Conversation

@nbbeeken
Copy link
Contributor

@nbbeeken nbbeeken commented Aug 22, 2022

Description

What is changing?

Skipping compression tests on gallium because of .end() hang
see NODE-4575 for followup

What is the motivation for this change?

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: <type>(NODE-xxxx)<!>: <description>
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@nbbeeken nbbeeken force-pushed the NODE-4574/skip-compression-node16 branch from 4e00057 to f93ab6d Compare August 22, 2022 21:29
@nbbeeken nbbeeken marked this pull request as ready for review August 22, 2022 21:29
Copy link
Contributor

@baileympearson baileympearson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

requesting changes

@nbbeeken nbbeeken added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Aug 23, 2022
@baileympearson baileympearson added Team Review Needs review from team and removed Primary Review In Review with primary reviewer, not yet ready for team's eyes labels Aug 23, 2022
@baileympearson baileympearson merged commit 2eb68e6 into main Aug 24, 2022
@baileympearson baileympearson deleted the NODE-4574/skip-compression-node16 branch August 24, 2022 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Team Review Needs review from team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants