Skip to content

Conversation

@baileympearson
Copy link
Contributor

@baileympearson baileympearson commented Aug 2, 2022

Description

What is changing?

Implements csfle prose test 16 - https://jira.mongodb.org/browse/NODE-4489. This is a regression test for rewrapManyDataKey.

Is there new documentation needed for these changes?

No.

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: <type>(NODE-xxxx)<!>: <description>
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@baileympearson baileympearson force-pushed the NODE-4489-add-regression-test-for-rewrapmanydatakey branch from 1fb70b7 to bf9c655 Compare August 3, 2022 15:27
@baileympearson baileympearson changed the title test: add prose test 16 test(NODE-4489): add prose test 16 Aug 3, 2022
@baileympearson baileympearson marked this pull request as ready for review August 3, 2022 17:53
@baileympearson baileympearson force-pushed the NODE-4489-add-regression-test-for-rewrapmanydatakey branch from 8f4094f to 094d725 Compare August 4, 2022 12:55
@baileympearson baileympearson changed the title test(NODE-4489): add prose test 16 test(NODE-4489): add CSFLE prose test 16 Aug 4, 2022
@durran durran added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Aug 9, 2022
@durran durran self-assigned this Aug 9, 2022
@baileympearson baileympearson requested a review from addaleax August 9, 2022 15:59
@baileympearson baileympearson requested a review from nbbeeken August 9, 2022 18:59
nbbeeken
nbbeeken previously approved these changes Aug 9, 2022
@durran durran added Team Review Needs review from team and removed Primary Review In Review with primary reviewer, not yet ready for team's eyes labels Aug 10, 2022
@durran durran removed their assignment Aug 10, 2022
@nbbeeken nbbeeken merged commit 6f5241f into main Aug 10, 2022
@nbbeeken nbbeeken deleted the NODE-4489-add-regression-test-for-rewrapmanydatakey branch August 10, 2022 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Team Review Needs review from team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants