test(NODE-4395): add csfle master && pinned commit tasks to CI #3334
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
durran
requested changes
Jul 27, 2022
Member
durran
left a comment
durran
left a comment
There was a problem hiding this comment.
I feel like this: https://github.com/mongodb/node-mongodb-native/blob/main/.evergreen/run-custom-csfle-tests.sh#L30 should maybe default back to master like before, so if we miss the variable in the future somewhere with new potential tasks we don't accidentally point at an old commit if we've bumped elsewhere. But I'm not too opinionated about it and am fine if it stays as is.
durran
approved these changes
Jul 28, 2022
dariakp
approved these changes
Jul 28, 2022
dariakp
requested changes
Jul 28, 2022
Contributor
dariakp
left a comment
dariakp
left a comment
There was a problem hiding this comment.
Quick question - I noticed both of the tasks that ran in the CI for this PR seem to have downloaded the same commit, is the variable currently set somewhere else, too, that's overriding master?
dariakp
approved these changes
Jul 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is changing?
A new task as been added to the custom dependency tests to test against libmongocrypt master. The existing task was also renamed to indicate that it tests against a pinned commit, instead of the latest master.