fix(NODE-4173): WIP send maxAwaitTimeMS to the server #3311
Conversation
src/cursor/abstract_cursor.ts
Outdated
| if (typeof options.maxTimeMS === 'number') { | ||
| this[kOptions].maxTimeMS = options.maxTimeMS; | ||
| if (typeof options.maxTimeMS === 'number' || typeof options.maxAwaitTimeMS === 'number') { | ||
| this[kOptions].maxAwaitTimeMS = options.maxAwaitTimeMS ?? options.maxTimeMS; |
There was a problem hiding this comment.
From: https://www.mongodb.com/docs/v6.0/reference/method/cursor.maxAwaitTimeMS/
This method, maxAwaitTimeMS(), sets a limit on how long a tailable cursor waits for the next response. maxTimeMS() sets a limit on total processing time.
I assume this is wrong then? (I assume it is. The legacy shell also sets getMoreCmd.maxTimeMS = this._maxAwaitTimeMS;.)
There was a problem hiding this comment.
Yea it's a strange case:
From the spec: "maxAwaitTimeMS - this option is an alias for maxTimeMS, used on getMore commands." So this is correct only for getMores so this is the wrong place to do this overriding. I'm going to write up some kickoff notes on the JIRA and I think the approach is that cursors should construct their GetMoreOperations and that would give them more control over this option.
nbbeeken
force-pushed
the
NODE-4173/test-maxAwaitTimeMS
branch
from
a7196cd to
297350b
Compare
nbbeeken
changed the title
nbbeeken
force-pushed
the
NODE-4173/test-maxAwaitTimeMS
branch
from
297350b to
b59f17c
Compare
|
#3319 |
Description
What is changing?
The AbstractCursor wil now save maxAwaitTimeMS or maxTimeMS to it's options as
maxAwaitTimeMSand the getMore command construction logic sends maxTimeMS to the server (as expected).What is the motivation for this change?
maxAwaitTimeMS was being ignored and not sent to the server. This corrects that.
Double check the following
npm run check:lintscript<type>(NODE-xxxx)<!>: <description>