fix(NODE-3712): SDAM should give priority to electionId over setVersion when updating topology #3109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbbeeken
force-pushed
the
NODE-3712/electionId-precedence
branch
from
eb1144c to
451b98f
Compare
nbbeeken
force-pushed
the
NODE-3712/electionId-precedence
branch
from
451b98f to
9b9649a
Compare
nbbeeken
force-pushed
the
NODE-3712/electionId-precedence
branch
2 times, most recently
from
6465b65 to
de9def7
Compare
Contributor
|
evergreen retry (I saw on slack it's possible to re-trigger evergreen with this comment so I tested it on this PR. ignore this) |
…on when updating topology
nbbeeken
force-pushed
the
NODE-3712/electionId-precedence
branch
from
de44de0 to
b9fb18e
Compare
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is changing?
In our SDAM machinery we are ensuring the electionId is checked before setVersion.
What is the motivation for this change?
This is a POC of mongodb/specifications#1122
Double check the following
npm run check:lintscript<type>(NODE-xxxx)<!>: <description>