Skip to content

fix(NODE-3344): allow setting defaultTransactionOptions with POJO rather than ReadConcern instance #3032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 10, 2021
Merged

fix(NODE-3344): allow setting defaultTransactionOptions with POJO rather than ReadConcern instance #3032

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bf861f0
fix: allow setting `defaultTransactionOptions` with POJO rather than …
vkarpov15 Oct 19, 2021
a1c6483
feat(NODE-3344): add type tests for txn options
durran Nov 9, 2021
1ac54cf
test(NODE-3344): move session type tests
durran Nov 10, 2021
c1467d8
fix(NODE-3344): fix linter error
durran Nov 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/transactions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { ReadPreference } from './read_preference';
import { MongoRuntimeError, MongoTransactionError } from './error';
import { ReadConcern } from './read_concern';
import { ReadConcern, ReadConcernLike } from './read_concern';
import { WriteConcern } from './write_concern';
import type { Server } from './sdam/server';
import type { CommandOperationOptions } from './operations/command';
Expand Down Expand Up @@ -63,7 +63,7 @@ const COMMITTED_STATES: Set<TxnState> = new Set([
export interface TransactionOptions extends CommandOperationOptions {
// TODO(NODE-3344): These options use the proper class forms of these settings, it should accept the basic enum values too
/** A default read concern for commands in this transaction */
readConcern?: ReadConcern;
readConcern?: ReadConcernLike;
/** A default writeConcern for commands in this transaction */
writeConcern?: WriteConcern;
/** A default read preference for commands in this transaction */
Expand Down
10 changes: 10 additions & 0 deletions test/types/mongodb.test-d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@ import type { FindCursor } from '../../src/cursor/find_cursor';
import type { Document } from 'bson';
import { Db } from '../../src';
import { Topology } from '../../src/sdam/topology';
import type { ClientSession } from '../../src/sessions';
import { ReadConcern, ReadConcernLevel } from '../../src/read_concern';
import * as MongoDBDriver from '../../src';

// We wish to keep these APIs but continue to ensure they are marked as deprecated.
Expand Down Expand Up @@ -38,6 +40,14 @@ const composedMap = mappedAgg.map<string>(x => x.toString());
expectType<AggregationCursor<string>>(composedMap);
expectType<string | null>(await composedMap.next());
expectType<string[]>(await composedMap.toArray());
expectType<ClientSession>(
client.startSession({ defaultTransactionOptions: { readConcern: { level: 'snapshot' } } })
);
expectType<ClientSession>(
client.startSession({
defaultTransactionOptions: { readConcern: new ReadConcern(ReadConcernLevel.local) }
})
);

const builtCursor = coll.aggregate();
// should allow string values for the out helper
Expand Down