fix(NODE-3452): readonly filters not permitted by typings #2927
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dariakp
added
the
Primary Review
dariakp
requested changes
Aug 2, 2021
Contributor
dariakp
left a comment
dariakp
left a comment
There was a problem hiding this comment.
Also, are we addressing the user's find override request?
by the way we should be able to configure the output type since with a filter we can have a different type than the schema type.
or is that addressed with the other projection ticket?
Co-authored-by: Daria Pardue <[email protected]>
Co-authored-by: Daria Pardue <[email protected]>
PaulEndri
reviewed
Aug 3, 2021
src/utils.ts
Outdated
| indexes.push(key + '_' + indexSpec[key]); | ||
| fieldHash[key] = indexSpec[key]; | ||
| indexes.push(key + '_' + (indexSpec as any)[key]); | ||
| fieldHash[key] = (indexSpec as any)[key]; |
Contributor
There was a problem hiding this comment.
Hi! Me again, hope I'm not bothering. Can you (in the interim, per the above conversation) fix needing to add the as any bit by iterating over the result of Object.entries instead? The following seems to make the transpiler happy:
Object.entries(indexSpec).forEach(([key, value]) => {
indexes.push(key + '_' + value);
fieldHash[key] = value;
});
Contributor
Author
There was a problem hiding this comment.
Good suggestion! thanks :)
dariakp
approved these changes
Aug 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Under certain usages typescript will disallow readonly arrays, when overriding the results of a find is a notable usage, look to the tests for a more complete list. Additionally the result of find was resulting the in the schema unioned with filter operators, there's a test to confirm that no longer occurs.