refactor(NODE-3291)!: Standardize error representation in the driver #2824
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dariakp
force-pushed
the
NODE-3291/standardize-error-representation
branch
4 times, most recently
from
296036d to
a325f93
Compare
dariakp
changed the title
dariakp
force-pushed
the
NODE-3291/standardize-error-representation
branch
11 times, most recently
from
167dc52 to
8842ab9
Compare
dariakp
commented
Jun 4, 2021
nbbeeken
suggested changes
Jun 7, 2021
Contributor
nbbeeken
left a comment
nbbeeken
left a comment
There was a problem hiding this comment.
I just have a number of clean up suggestions which some could be left to the follow up work that's coming up soon, I leave that to you to decide. There's on instance where a MongoError.create call's arguments were preserved where they need not be. Beyond that this is looking very ready to merge.
…should already be processed
dariakp
force-pushed
the
NODE-3291/standardize-error-representation
branch
from
8842ab9 to
ed91110
Compare
nbbeeken
requested review from
a team,
durran and
emadum
and removed request for
a team
durran
approved these changes
Jun 10, 2021
ljhaywar
pushed a commit
that referenced
this pull request
Nov 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
NODE-3291
BREAKING: Previously thrown
TypeErrorinstances have been converted toMongoDriverErrorinstances andMongoParseErrorinstances (which extend from the same class). Error names have changed to be more specific.All thrown errors across the codebase have been converted to extend from a specific subclass of
MongoError:MongoServerErrorwhen wrapping errors returned from the server on specific queries,MongoDriverErrorwhen generated by the driver,MongoNetworkErrorwhen associated with a network connection failure,MongoSystemErrorto represent errors associated with general system configuration.