CLOUDP-349099: Renamed 2nd level Ginkgo labels

[igor-karpukhin]

Summary

Renamed 2nd level Ginkgo labels

Checklist

• Have you linked a jira ticket and/or is the ticket in the title?
• Have you checked whether your jira ticket required DOCSP changes?
• Have you checked for release_note changes?
• Have you signed our CLA?

Reminder (Please remove this when merging)

• Please try to Approve or Reject Changes the PR, keep PRs in review as short as possible
• Remember the following Communication Standards - use comment prefixes for clarity:
  • blocking: Must be addressed before approval.
  • follow-up: Can be addressed in a later PR or ticket.
  • q: Clarifying question.
  • nit: Non-blocking suggestions.
  • note: Side-note, non-actionable. Example: Praise
  • --> no prefix is considered a question

[josvazg]

Code changes LGTM, but I would like to see the CI can run test/e2e/* without issues.

BTW, I see a weird CI issue right now. Does this PR need rebasing on the latest main maybe?

[josvazg]

@igor-karpukhin focus prefix filtering is not working for selected e2e or int tests because it is not being used. You need toi pass SKIP_PREFIXES='["focus"]' to actually skip one or more prefixes.

One sample usage is at the e2e2 tests:
https://github.com/mongodb/mongodb-atlas-kubernetes/blob/main/.github/workflows/tests-e2e2.yaml#L76

      - name: Compute Test Matrix
        id: set-matrix
        env:
          PR_LABELS: ${{ steps.get-labels.outputs.result || '["test/e2e2/*"]' }}
          E2E2_LABELS: ${{ env.e2e2_labels }}
          USE_JSON: true
          SKIP_PREFIXES: "[\"focus\"]"
...
        run: |
          # Nightly runs all tests, overriding PR labels as '["test/e2e2/*"]'
          if [ "${GITHUB_REF}" == "refs/heads/main" ] && [ "${EVENT_NAME}" == "schedule" -o "${EVENT_NAME}" == "workflow_dispatch" ];then
            PR_LABELS='["test/e2e2/*"]'
            echo "Nightly runs all tests"
          fi
          echo PR_LABELS="${PR_LABELS}"
          echo E2E2_LABELS="${E2E2_LABELS}"
          make compute-labels
          ./bin/ginkgo-labels > result.json
          echo "E2E2 tests to execute $(cat result.json | jq -c .e2e2)"
          echo "e2e2_matrix=$(cat result.json | jq -c .e2e2)" >> $GITHUB_OUTPUT

[josvazg]

Current Ci issue seems related to the recent removal of transient CRDs:

+ kustomize build --load-restrictor LoadRestrictionsNone config/release/dev/allinone
# Warning: 'commonLabels' is deprecated. Please use 'labels' instead. Run 'kustomize edit fix' to update your Kustomization automatically.
Error: accumulating resources: accumulation err='accumulating resources from '../../base/allinone': read /github/workspace/config/release/base/allinone: is a directory': recursed accumulation of path '/github/workspace/config/release/base/allinone': accumulating resources: accumulation err='accumulating resources from '../../../crd': read /github/workspace/config/crd: is a directory': recursed accumulation of path '/github/workspace/config/crd': accumulating resources: accumulation err='accumulating resources from 'bases/': read /github/workspace/config/crd/bases: is a directory': couldn't make target for path '/github/workspace/config/crd/bases': unable to find one of 'kustomization.yaml', 'kustomization.yml' or 'Kustomization' in directory '/github/workspace/config/crd/bases'

We probably need to make bundle somewhere in that job.

Failing step is:

      - name: Generate configuration for the tests
        uses: ./.github/actions/gen-install-scripts
        with:
          IMAGE_URL: ${{ env.GHCR_REPO }}:${{ steps.prepare.outputs.tag }}
          VERSION: ${{ needs.detect-tests.outputs.next_version }}
          ENV: dev

./.github/actions/gen-install-scripts is used successfully from other workflows, so probably we need to make bundle before calling it?

[josvazg]

Current Ci issue seems related to the recent removal of transient CRDs:

+ kustomize build --load-restrictor LoadRestrictionsNone config/release/dev/allinone
# Warning: 'commonLabels' is deprecated. Please use 'labels' instead. Run 'kustomize edit fix' to update your Kustomization automatically.
Error: accumulating resources: accumulation err='accumulating resources from '../../base/allinone': read /github/workspace/config/release/base/allinone: is a directory': recursed accumulation of path '/github/workspace/config/release/base/allinone': accumulating resources: accumulation err='accumulating resources from '../../../crd': read /github/workspace/config/crd: is a directory': recursed accumulation of path '/github/workspace/config/crd': accumulating resources: accumulation err='accumulating resources from 'bases/': read /github/workspace/config/crd/bases: is a directory': couldn't make target for path '/github/workspace/config/crd/bases': unable to find one of 'kustomization.yaml', 'kustomization.yml' or 'Kustomization' in directory '/github/workspace/config/crd/bases'

We probably need to make bundle somewhere in that job.

Failing step is:

      - name: Generate configuration for the tests
        uses: ./.github/actions/gen-install-scripts
        with:
          IMAGE_URL: ${{ env.GHCR_REPO }}:${{ steps.prepare.outputs.tag }}
          VERSION: ${{ needs.detect-tests.outputs.next_version }}
          ENV: dev

./.github/actions/gen-install-scripts is used successfully from other workflows, so probably we need to make bundle before calling it?

This issue requires a separate fix. This PR will be blocked until that is fixed.