Skip to content

Conversation

abr-egn
Copy link
Contributor

@abr-egn abr-egn commented Mar 16, 2023

RUST-1501

This implements the new data collection from environment variables and the associated fallback logic to keep the handshake within the size limit.

@abr-egn abr-egn requested a review from isabelatkinson March 16, 2023 21:57
Copy link
Contributor

@isabelatkinson isabelatkinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes LGTM. Is it expected that users will be setting these environment variable values? If so, should we document somewhere how they should do so?

@abr-egn
Copy link
Contributor Author

abr-egn commented Mar 20, 2023

Code changes LGTM. Is it expected that users will be setting these environment variable values? If so, should we document somewhere how they should do so?

Nope, they're set by the FaaS runtime, no user action needed :)

@abr-egn abr-egn merged commit ca7bf1d into mongodb:main Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants