extend error types to impl serialization #797
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: borngraced <[email protected]>
Signed-off-by: borngraced <[email protected]>
0xsot
changed the title
|
Hi! Thanks for the contribution. Unfortunately, variable interpolation in format strings isn't supported in our MSRV of 1.57 - can you revert that portion of your change? |
This reverts commit 5839ecd.
all done |
|
This will go out with the next release (which coincidentally will be in the next week or so) - thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #796
Also, fixed cargo clippy and remove unnecessary lifetime annotations