RUST-2219 Cherrypick domain name parsing fix into 3.2.x #1404
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abr-egn
force-pushed
the
RUST-2219/cherrypick
branch
from
f54310c to
ebccc49
Compare
There was a problem hiding this comment.
changes LGTM, but I think merging will be blocked on making the MSRV task pass - maybe cherry-picking #1371 as well and setting rust-version to 1.71.1 will fix it?
Good call - that did indeed fix it :) |
isabelatkinson
approved these changes
Jun 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RUST-2219
This also strips out the
gitdependency references forbsonandmongocryptbecause those are currently WIP for the bson 3.x work (otherwise local compilation of this branch fails because bson at head is no longer 2.x), and not needed for a release branch.Edit: it turns out a whole bunch of cherrypicks are needed to have an actual working evergreen patch run. The clippy version bump is morally a cherrypick from #1372. MSRV will have to stay broken because per our own policy we can't bump that in a patch release.