Skip to content

Fix compilation when dns-resolver is disabled #1292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 27, 2025
Merged

Fix compilation when dns-resolver is disabled #1292

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c3aa5cb
minor: remove call to deprecated function
isabelatkinson Jan 23, 2025
8c95d0b
Fix compilation when dns-resolver is disabled
isabelatkinson Jan 24, 2025
c39b4b9
revert clippy fix
isabelatkinson Jan 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/srv.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ pub(crate) struct LookupHosts {
}

impl LookupHosts {
#[cfg(feature = "dns-resolver")]
pub(crate) fn validate(mut self, original_hostname: &str, dm: DomainMismatch) -> Result<Self> {
let original_hostname_parts: Vec<_> = original_hostname.split('.').collect();
let original_domain_name = if original_hostname_parts.len() >= 3 {
Expand Down Expand Up @@ -261,7 +262,10 @@ pub(crate) struct SrvResolver {}

#[cfg(not(feature = "dns-resolver"))]
impl SrvResolver {
pub(crate) async fn new(_config: Option<ResolverConfig>) -> Result<Self> {
pub(crate) async fn new(
_config: Option<ResolverConfig>,
_srv_service_name: Option<String>,
) -> Result<Self> {
Ok(Self {})
}

Expand Down