Skip to content

Conversation

@GromNaN
Copy link
Member

@GromNaN GromNaN commented Jun 21, 2023

Fix PHPLIB-1158

Psalm detects the lowest supported PHP version by reading the composer.json (doc)

Copy link
Member

@jmikola jmikola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I noted the Evergreen test failures are due to Int64 comparisons, so not relevant.

</file>
<file src="src/Exception/InvalidArgumentException.php">
<UnsafeInstantiation occurrences="2">
<UnsafeInstantiation occurrences="1">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume you regenerated the baseline for this PR?

Copy link
Member Author

@GromNaN GromNaN Jun 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exactly, that's mostly resolved issues.

@jmikola jmikola merged commit eb2a813 into mongodb:master Jun 21, 2023
@GromNaN GromNaN deleted the PHPLIB-1158 branch June 21, 2023 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants