-
Notifications
You must be signed in to change notification settings - Fork 1.3k
CSHARP-5731: Fix atlas search tests failures #1775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
echo "HTTP Status: $http_status" | ||
assume-ec2-role: | ||
assume-aws-test-secrets-role: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changed to a more descriptive name
- "AWS_SESSION_TOKEN" | ||
script: | | ||
${PREPARE_SHELL} | ||
. ${DRIVERS_TOOLS}/.evergreen/secrets_handling/setup-secrets.sh drivers/atlas-qa |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I migrated test configuration from Evergreen project variables to AWS Secrets Manager
result[2].Title.Should().Be("National Mechanics"); | ||
result[3].Title.Should().Be("Genevieve"); | ||
result[4].Title.Should().Be("Speedway Junky"); | ||
result[3].Title.Should().Be("Speedway Junky"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some data changed in the sample data used for tests in the new cluster so I had to update this.
{ | ||
[BsonElement("plot_embedding")] | ||
public double[] Embedding { get; set; } | ||
public BinaryVectorFloat32 Embedding { get; set; } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The plot_embedding
field is stored as binary data in the database, but our code was trying to deserialize it directly to an array of doubles, which fails. I can't remember why this worked previously but my guess is that the sample data in the old cluster stored plot_embedding
as a double array rather than binary.
tested in this patch