CSHARP-3984: Remove BinaryConnection.DropBox #1754
Merged
+56
−408
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanych-sun
requested review from
papafe,
rstam and
BorisDog
and removed request for
a team and
papafe
sanych-sun
commented
Aug 13, 2025
| { | ||
| helper.ReceivingMessage(); | ||
| using (var buffer = ReceiveBuffer(operationContext, responseTo)) | ||
| while (true) |
There was a problem hiding this comment.
We need this because driver could stop waiting on response from the server at any moment, and if it happened we should ignore server's response that is not the current request. We used to have exactly the same behavior with DropBox, with only difference that DropBox would store such response forever.
There was a problem hiding this comment.
And just to have full picture: we will change this in https://jira.mongodb.org/browse/DRIVERS-2884
Accordingly to the DRIVERS-2884 Driver should perform reading of pending response BEFORE sending request.
sanych-sun
force-pushed
the
csharp3984
branch
from
339a283 to
cfe823f
Compare
sanych-sun
force-pushed
the
csharp3984
branch
from
cfe823f to
f04b426
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.