[INTPYTHON-TODO]: PoC Expression Conversion Abstraction #373
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces an abstraction to convert some of our simple $expr queries to $match queries without $expr in them. If the $expr query cannot be converted to a $match query, it will leave it as a $expr. This behavior is nested. Currently this is limited to
$eq
and$in
operations for now, but in the future can be extended to other$expr
conversions.This only affects the querying done in
self.match_mql
as the querying for lookups, groupings, or aggregation pipelines are out of scope for this pr.Changes in this PR
QueryOptimizer
abstraction (which can be changed; it doesn't store state so it does not need to remain an object)ExpressionConverters
which house the logic for converting queries from$expr
usage to their$match
equivalents.$eq
,$in
,$and
,$or
in drilling down of expression conversion.Test Plan
python manage.py shell
See an example query below.Screenshots (grabbed text)
Callouts
QueryOptimizer
should be removed and left as its functions if it is not going to retain state. Initialization is unnecessary.$getField
converter is made.