-
Notifications
You must be signed in to change notification settings - Fork 72
DRIVERS-2328 Use Python and Mongo Shell for AWS Testing #306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
cc @dariakp |
|
@blink1073 what are the proposed driver changes supposed to look like? I did a commit to run an Evergreen patch on the Node driver against your fork/branch to see what this looked like and I get some AWS tests passing, but some failing as well. My driver changes: mongodb/node-mongodb-native@57c3f65 |
|
Here's my patch: In the ones that are passing in your patch, I see the expected "Creating user" output in the log. Perhaps set each command to use "bash" and add a "set -ex" so we can debug? |
|
@markbenvenuto would you like to merge any of this work back into the server test suite so that we can keep parity? |
|
I tested this using the .NET driver (I used that for all my testing as PHP does not implement these tests itself), and the only test that failed was the ecs test. However, the .NET driver has some special logic there to move the test file around, so I'd attribute the failure to my setup rather than assume it was the fault of these changes. I'll wait for @durran to run a new patch with debug output. |
|
I cleaned up the patch to just test latest and added debug, only passing 3 of the 8. https://spruce.mongodb.com/version/645d33893627e020f687a8a5/tasks?sorts=STATUS%3AASC%3BBASE_STATUS%3ADESC I haven't dug into the cause as of yet, but my changes look consistent with the Python changes. This is the latest diff: mongodb/node-mongodb-native@9584639 But I assume it's something in our setup, so I won't hold this PR up. |
|
You need to add |
|
@durran you need to use |
durran
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From a functional standpoint these work on the Node branch now. I'll let someone else review the Python code itself.
alcaeus
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM as well. I ran into failures when testing this with the C# driver but I assume it's connected to the setup (which I'm not entirely familiar with) rather than the tests itself.
What I didn't test was whether this will have a breaking impact on drivers, i.e. do drivers have to modify their evergreen config as soon as we merge this, or is this something they can opt into?
|
No changes are necessary, it is opt-in. I ran an EG patch using this branch but with no other changes to the config, and it passed. |
The script can be called as follows:
Tested with the Python driver with all 5 variants here: https://spruce.mongodb.com/task/mongo_python_driver_aws_auth_test__platform~ubuntu_18.04_python_version~3.7_aws_auth_test_6.0_patch_873032660bf22d09cbf0013f6b077196d0b95f40_645aaaa63e8e86cbdcbd8933_23_05_09_20_18_56/logs?execution=1&sortBy=STATUS&sortDir=ASC
Linked PR: mongodb/mongo-python-driver#1220