-
Notifications
You must be signed in to change notification settings - Fork 90
fix: disable MCP auto start and instead request on first load and new connection attempts VSCODE-704 #1132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
himanshusinghs
merged 36 commits into
main
from
fix/VSCODE-704-flip-mcp-auto-start-behaviour
Oct 6, 2025
Merged
fix: disable MCP auto start and instead request on first load and new connection attempts VSCODE-704 #1132
Changes from all commits
Commits
Show all changes
36 commits
Select commit
Hold shift + click to select a range
aea317c
chore: disable MCP auto start and instead request
himanshusinghs f2364e1
fix: bind DataService.disconnect to correct instance
himanshusinghs 6c48e71
chore: enable readOnly mode by default
himanshusinghs aea2eaa
chore: remove unused type
himanshusinghs c5a65da
chore: fix tests with correct expectations
himanshusinghs f6b6b00
Update src/test/suite/mcp/mcpController.test.ts
himanshusinghs c94498f
chore: apply copilot suggestions
himanshusinghs adcab74
chore: no exclusive tests
himanshusinghs df9c0f3
chore: add missing hosting_mode for telemetry data
himanshusinghs e4be477
chore: remove unused async wrapper
himanshusinghs 1b14b66
chore: avoid relying on internals for tests
himanshusinghs 58c880f
chore: use pre-build logger
himanshusinghs ee2e851
chore: clarify the comment
himanshusinghs 5e23a07
chore: disable eslint just for the lines
himanshusinghs f03b737
chore: type the returned value of getMCPAutoStartConfig
himanshusinghs 13cbb37
Merge remote-tracking branch 'origin/main' into fix/VSCODE-704-flip-m…
himanshusinghs a0cc53e
chore: coerce unknown stored values to known value
himanshusinghs fedd5d1
chore: handle multiple mcp client connections
himanshusinghs 03957d1
chore: remove unused imports
himanshusinghs 0cff996
Merge remote-tracking branch 'origin/main' into fix/VSCODE-704-flip-m…
himanshusinghs 98a4187
chore: bump mongodb-mcp-server
himanshusinghs f638bc6
chore: add tests to verify multi client handling
himanshusinghs d3d6448
chore: disable eslint just for the lines
himanshusinghs 90be6f3
chore: rename clientConnectionManager to mcpConnectionManager
himanshusinghs 955a371
chore: add test for separate client states
himanshusinghs 0a4f818
chore: add test validating that MCP server shutdown closes Connection…
himanshusinghs 5f77f59
chore: log when prompted and remove one line func
himanshusinghs 5a4e165
Merge remote-tracking branch 'origin/main' into fix/VSCODE-704-flip-m…
himanshusinghs 1613071
chore: use typed autoStartConfig retriever
himanshusinghs 6f161a8
chore: update test to reflect non-coercion
himanshusinghs 8f8606f
chore: do not show popup on extension activate
himanshusinghs a1954c8
chore: correctly place the log
himanshusinghs 2786c47
chore: refactor log placement a little
himanshusinghs d09a052
chore: remove super long timeout
himanshusinghs d2187f3
chore: add clarifying comments and use debug notifications
himanshusinghs 4f39d31
chore: make createConnectionManager a static func
himanshusinghs File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,3 +11,5 @@ constants.json | |
.eslintcache | ||
.sbom | ||
src/test/ai-accuracy-tests/test-results.html | ||
.yalc | ||
yalc.lock |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.