Skip to content

Conversation

nirinchev
Copy link
Collaborator

Proposed changes

Checklist

@nirinchev nirinchev requested a review from a team as a code owner September 12, 2025 09:47
@nirinchev nirinchev requested review from a team, Copilot and himanshusinghs and removed request for a team September 12, 2025 09:47
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds an untrusted data wrapper to the export resource functionality. The changes modify how exported data is presented by wrapping the actual data content with untrusted data markers and providing a document count summary.

  • Adds untrusted data wrapping to exported MongoDB data content
  • Tracks the number of documents transformed during export
  • Updates test to verify the new wrapped format and extract data for validation

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
tests/integration/resources/exportedData.test.ts Updates test to verify untrusted data wrapper format and extract content for validation
src/resources/common/exportedData.ts Implements untrusted data formatting with document count in export resource
src/common/exportsManager.ts Adds document counting functionality and returns both content and count from exports

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Collaborator

@himanshusinghs himanshusinghs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 💯 Just need to check the test failures.

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 17671857423

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 44 of 46 (95.65%) changed or added relevant lines in 2 files are covered.
  • 31 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.06%) to 81.466%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/common/exportsManager.ts 38 40 95.0%
Files with Coverage Reduction New Missed Lines %
src/common/connectionManager.ts 6 87.86%
src/tools/atlas/connect/connectCluster.ts 10 77.22%
src/common/config.ts 15 89.98%
Totals Coverage Status
Change from base Build 17650490388: -0.06%
Covered Lines: 4866
Relevant Lines: 5876

💛 - Coveralls

@nirinchev nirinchev merged commit e71e2ba into main Sep 12, 2025
18 checks passed
@nirinchev nirinchev deleted the ni/untrusted-exports branch September 12, 2025 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants