Jojo travis #4
Open
Jojo travis #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* implemented dictionary contains * tests for tango*dictionary * job IDs may be strings * bug with jobqueue fix * removed unnecessary .keys() calls in jobQueue * removed unnecessary .keys() calls in preallocator * additionally dict testing * change assert type Co-authored-by: claire <[email protected]>
* fix for shutil on ubuntu 18.04 * Use host volume path when starting jobs * Add instance name to path * self fix
* comments & error handling for getNextId * inline comments + docs * remove early return in get next id
* change get next pending job in manager to be blocking * add unassigned job q to jobq * remove remove api which is unused * updated jobQueue to use unassigned q * updated tango objects with the new queue support * update tests * fixes for unit tests * add unit test and add * fix use of remove in jobQueue + unit test * added unit tests * added tests for TangoQueue object * some comments * shifted unassignedJobs get before lock acquire * updated makeDead * shift order of remove * add reuseVm instead of getNextPendingJobReuse * returned the remove api * remove unassigned job in makeDead * sleep a while while waiting for vm * fixed nit
* Added tests for preallocator * Added comments for tests * import errors * tests fixed * tests fixed Co-authored-by: mojojojo <[email protected]>
* Upgrade to 18.04 and more optimized dockerfile * add sudo Co-authored-by: EC2 Default User <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes autolab#123.
Changes proposed in this PR: