Adding support for JDK 11 and fixing integration test

[nickwongdev]

No description provided.

[dzmitrys-dev]

looking forward this PR for oracle jdk and openjdk 11 support

[nwong-blz]

Could you guys at least merge this pull request in as of the three, it is the least impactful, works, and passes all tests?

[nickwongdev]

For everyone waiting on this pull request to be merged, I have started the process for hosting a fork of the project on Maven Central. Please add your support for this fork to be added to maven central here:
https://issues.sonatype.org/browse/OSSRH-44691

Ignore the above failures, I'll fix the build issues caused by this automatically updated pull request so the checks will start passing again.

[nickwongdev]

Fork of project now synced. Searches will take a while longer to update, but should be up by EOB today.

Direct Download:
https://search.maven.org/remotecontent?filepath=com/nickwongdev/aspectj-maven-plugin/1.12.1/aspectj-maven-plugin-1.12.1.jar

Maven Dependency:

<dependency>
  <groupId>com.nickwongdev</groupId>
  <artifactId>aspectj-maven-plugin</artifactId>
  <version>1.12.1</version>
</dependency>

[missedone]

any update on the PR review and merge process? anybody maintains this project?

[alievmirza]

maybe @davidkarlsen might shed light on current status for that changes

[teenaBuchade]

Any updates on when support for JDK 11 will be available.

[akpai]

Any update on when this PR will be merged and support for jdk 11 will be available?

[sanyalpp]

Why is this PR not getting merged? We need this Open JDK 11 support guys!

[AkshayIyer12]

Any update on this?

[mariaoks]

any update?
when can I use this for java 11?
org.codehaus.mojo
aspectj-maven-plugin
1.11

[vigneshse]

Execution default of goal org.codehaus.mojo:aspectj-maven-plugin:1.11:compile failed: Plugin org.codehaus.mojo:aspectj-maven-plugin:1.11 or one of its dependencies could not be resolved: Could not find artifact com.sun:tools:jar:11.0.3 at specified path /Library/Java/JavaVirtualMachines/adoptopenjdk-11.jdk/Contents/Home/../lib/tools.jar ->

Injection of the newer version solves the above issue.

<dependency>
  <groupId>com.nickwongdev</groupId>
  <artifactId>aspectj-maven-plugin</artifactId>
  <version>1.12.1</version>
</dependency>

Any update on the PR?

[Shanky2304]

Can we merge this now? I couldn't understand if there's another blocker here? This looks to be the issue blocking version 1.11.1 release.

[dheid]

Can I help with anything to move this forward?

[pankajagrawal16]

It will be great if we can have an official version that works with newer java versions.

[AjitDas]

can this feature be merged and released please please ? it's been a while since this critical feature is not implemented.

[pankajagrawal16]

Hi @nickwongdev, Anything I could help with to expedite this? Happy to help.:)

[softwarebrahma]

Can this be merged please?....is there something i can do to help?...we use this heavily & are unable to migrate to java 11 without this.

[softwarebrahma]

Hi @nickwongdev, Anything I could help with to expedite this? Happy to help.:)

Hi @nickwongdev, Same here...is there anything I could help with here?

[mustaphazorgati]

Hey @nickwongdev!
I just saw this PR. We need JDK11 support too. I think one reason why this is not merged is because you have a lot of noise within your PR. Should we create a PR which just contains the necessary changes to get this done?

[kriegaex]

No, @mustaphazorgati, that is not the reason. It is much simpler: The Mojohaus plugin has not been actively maintained for quite a long time now (~3 years). @davidkarlsen is too busy with other things, as he told me, and Mojohaus never appointed @nickwongdev the maintainer. The story is a bit more complicated than this, but it is the short version for you.

[mustaphazorgati]

Hey @kriegaex,

thank you for your quick reply. So we have to wait and see what happens? Until then just use the fork from @nickwongdev? :P

[kriegaex]

Kind of, yes. I thought about taking care of the plugin myself, but I want to avoid having to comply to a lot of internal regulations at Mojohaus. I have never written a Maven plugin by myself either, so I am not an expert, rather an AspectJ buff. I would maybe provide PRs for the plugin in order to keep it up to the same level as AspectJ, but who should process them? At the end of the day I would create another fork.

[nickwongdev]

Unfortunately I can no longer contribute to any open source initiatives at this time. So I suggest you fork what I have if you need additional changes.

…

On Fri, Mar 19, 2021 at 7:55 AM Alexander Kriegisch < ***@***.***> wrote: Kind of, yes. I thought about taking care of the plugin myself, but I want to avoid having to comply to a lot of internal regulations at Mojohaus. I have never written a Maven plugin by myself either, so I am not an expert, rather an AspectJ buff. I would maybe provide PRs for the plugin in order to keep it up to the same level as AspectJ, but who should process them? At the end of the day I would create another fork. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#45 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAWQ4G62DG5CZIALOWETFNTTENQVPANCNFSM4GHBEWGA> .

[kriegaex]

Unfortunately I can no longer contribute to any open source initiatives at this time. So I suggest you fork what I have if you need additional changes.

Done: https://github.com/dev-aspectj/aspectj-maven-plugin. The read-me briefly explains

• the project history and also
• new features (Java 14-16, support for --module-path, --enable-preview compiler options).

See eclipse-aspectj/aspectj#41 (comment) if you want to use a snapshot from my Maven repository on aspectj.dev instead of building by yourself.

[olamy]

Thanks. support to java 16 now in master.

[pankajagrawal16]

Are there plans to make an official release soon? @olamy @bmarwell

[bmarwell]

I'd love to do a release soon. Mid of June perhaps?
I am still browsing the other issues. Some of them are already resolved.

[kriegaex]

@pankajagrawal16, on Maven Central you find the AspectJ.dev release 1.13.M3. As mentioned above, the source code is here and also the plugin documentation.

Just like the current snapshot of this repository, the AspectJ.dev version is based on AspectJ 1.9.7.M3. I have been developing both the upcoming AspectJ version and the AspectJ Maven plugin in parallel, so they fit together. Of course, you can also wait for a release of this variant, if you prefer and if you don't trust an AspectJ committer.

Please be aware of the fact that both plugins can only depend on an AspectJ milestone in order to support Java 15/16, until there is a final release of AspectJ 1.9.7, which I cannot promise we shall release until mid June. Andy Clement and myself as current maintainers need to wait for some internal Eclipse reviews to be finished, before we can release a final version. But don't worry, you can use either of the two plugin variants and AspectJ 1.9.7.M3. The latter should be pretty stable, all tests are passing and we do not have plans to change major things until the release. OSS needs user feedback, so please support the guys here and the AspectJ team. 🙂

[bmarwell]

I can confirm that Alex' plugin is a good option for now. He did good work, and I might cherry pick some of his commits back (so the authorship does not get lost).
I was even thinking of adding his fork to the front page.

[kriegaex]

I might cherry pick some of his commits back (so the authorship does not get lost)

@bmarwell, if you do, please let us talk first. Actually, let us talk before the team here continues to fix or extend anything else. The code bases are still pretty much the same, but not quite, and the build files and Javadocs have also begun to diverge. This was all avoidable, if any of you had accepted my invitation to talk before reactivating this long neglected code base here. Let us cooperate rather then hack away and let it diverge further. But please, let us avoid writing further offline messages. I prefer a chat tool like Telegram or Gitter. (You can use Gitter with your GitHub account.) Too much chaos has already arisen. Please, I am asking kindly.

[bmarwell]

I definitely wouldn't mind! I will ask ASF Infra if we can use the ASF slack for mojohaus. If not, Gitter is probably the second-best option (looking for a #mojohaus channel).

[kriegaex]

Lately, I opened an AspectJ Slack because Andy has to use Slack at his daytime job anyway and knows it. Currently, it is just us two there. I could open a channel there, but am not sure if then you can also read all the AspectJ internal stuff. If there is a way to created a closed group, it would be an option. I have not looked into admin options, not having used Slack a lot before.

But I am just one person, you are multiple ones. So probably it is better if you open a channel somewhere comfortable for you guys.

How about some old-fashioned audio chat for a start? I want to specifically talk to you. Same goes for Olivier, separately. I believe in personal connections. It makes people see others as people too, not as anonymous resources. It saves a ton of time, too.

[weaselmetal]

Is this the best ticket to follow if I want to stay informed when a new version of this plugin is available?
Should the ticket perhaps be reopened until a new version of the plugin has been released?
For anyone who hasn't been following this conversation already, it's hard to even figure out that this project has been revived and things are happening again.

[bmarwell]

it's hard to even figure out that this project has been revived

I usually take a look at the last commits, when they happened and how frequently.

But yes, I am going to make a release soon, hopefully this month.

[mbesoft]

Looking forward to use it ^^

[jan-swiecki]

Yes, indeed, waiting for the update as well!

[olamy]

1.14.0 released